Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix express type definitions #26

Closed
wants to merge 1 commit into from
Closed

Fix express type definitions #26

wants to merge 1 commit into from

Conversation

leedm777
Copy link

@leedm777 leedm777 commented Dec 6, 2020

This PR cherry-picks just the type definition fixes from #24.

A recent change to the express.static type (DefinitelyTyped/DefinitelyTyped#48964) exacerbated this problem and causes express.static usage to fail if bunyan-middleware has been imported.

src/lib/express.ts:47:16 - error TS2769: No overload matches this call.
  The last overload gave the following error.
    Argument of type 'RequestHandler<Response<any>>' is not assignable to parameter of type 'Application'.

47   app.use("/", express.static("./assets"));
                  ~~~~~~~~~~~~~~~~~~~~~~~~~~

tellnes pushed a commit that referenced this pull request Dec 8, 2020
@dmaretskyi @tellnes
Fix express type defenitions
42fe680 
GH-PR: #26
@tellnes
Copy link
Owner

tellnes commented Dec 8, 2020

Hi, thanks

I fixed a spelling error in the commit message and merged it as 42fe680 and published as v1.0.1

@tellnes tellnes closed this Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leedm777 @tellnes @dmaretskyi